[PR #9873/c9698c8e backport][3.12] Make creating RequestInfo backwards compatible with 3.10
#9886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
(cherry picked from commit c9698c8)
CodSpeed Performance ReportMerging #9886 will not alter performanceComparing Summary
|
bdraco
deleted the
patchback/backports/3.12/c9698c8ecadc344a55e8b05d5c43391e39443ad9/pr-9873
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9873 as merged into master (c9698c8).
It was unexpected that this object was being created directly outside of
aiohttpinternals. While it looks like its only used for mocking internal state downstream, we can accommodate that by subclassing theNamedTupleand providing a__new__while keeping the fastertuple.__new__internally.We might remove the back-compat later in 4.x development cycle, however since its currently being used downstream to mock internals and there isn't a better prescribed way to do that, leave it for now.
fixes #9866