Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for add_head, update doc for add_get. #1944

Merged
merged 2 commits into from
Jun 1, 2017
Merged

Add doc for add_head, update doc for add_get. #1944

merged 2 commits into from
Jun 1, 2017

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jun 1, 2017

Also method signatures are changed to get rid of *args usage.
It helps to get better error info.

@asvetlov asvetlov merged commit 8841ae9 into master Jun 1, 2017
@asvetlov asvetlov deleted the fixups branch June 1, 2017 19:51
@codecov-io
Copy link

codecov-io commented Jun 1, 2017

Codecov Report

Merging #1944 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1944   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files          37       37           
  Lines        7610     7610           
  Branches     1328     1328           
=======================================
  Hits         7386     7386           
  Misses        101      101           
  Partials      123      123
Impacted Files Coverage Δ
aiohttp/web_urldispatcher.py 99.41% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347cbf3...0b618f4. Read the comment docs.

asvetlov pushed a commit that referenced this pull request Jun 19, 2017
* fixed consecutive calling for write_eof on Response

* fixed consecutive calling for write_eof on Response

added records to CHANGES.rst and CONTRIBUTORS.txt

* Update pytest from 3.1.0 to 3.1.1

* Update pytest from 3.1.0 to 3.1.1

* Update ipython from 6.0.0 to 6.1.0

* Add doc for add_head, update doc for add_get. (#1944)

* Add doc for add_head, update doc for add_get.

* Update CHANGES

* Fix deprecation warning in test suite

* fixed consecutive calling for write_eof on Response

fixed merge conflicts
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants