ClientSession.__aexit__ returns ClientSession.close coroutine #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2064 +/- ##
==========================================
+ Coverage 97.08% 97.08% +<.01%
==========================================
Files 38 38
Lines 7684 7689 +5
Branches 1343 1344 +1
==========================================
+ Hits 7460 7465 +5
Misses 102 102
Partials 122 122
Continue to review full report at Codecov.
|
asvetlov
reviewed
Jul 6, 2017
aiohttp/client.py
Outdated
| def __aexit__(self, exc_type, exc_val, exc_tb): | ||
| self.close() | ||
| return self.close() |
There was a problem hiding this comment.
Why return? I think it should be yield from
There was a problem hiding this comment.
I have done timeit for those two cases, and your variant is faster. Fixed it.
litwisha
added a commit
to litwisha/aiohttp
that referenced
this pull request
Jul 11, 2017
…aio-libs#2064)" This reverts commit 4ecb633.
cecton
added a commit
to cecton/aiohttp
that referenced
this pull request
Jul 13, 2017
psf-chronographer
bot
added
the
bot:chronographer:provided
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Correct session closing for asynchronous context manager.
Related issue number
#2063
Checklist
changesfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.