Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom proxy headers #2272

Merged
merged 3 commits into from
Sep 16, 2017
Merged

Conversation

cecton
Copy link
Contributor

@cecton cecton commented Sep 15, 2017

Related issue number

#2001

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the changes folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@cecton cecton force-pushed the add-custom-proxy-headers branch 3 times, most recently from 8f3d1fd to fcb730e Compare September 15, 2017 18:58
@cecton
Copy link
Contributor Author

cecton commented Sep 15, 2017

@dshoe1989 if you wish to review this PR, this will be more than welcome (I haven't change anything)

@codecov-io
Copy link

codecov-io commented Sep 15, 2017

Codecov Report

Merging #2272 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
+ Coverage   97.29%   97.29%   +<.01%     
==========================================
  Files          39       39              
  Lines        8010     8016       +6     
  Branches     1387     1388       +1     
==========================================
+ Hits         7793     7799       +6     
  Misses         94       94              
  Partials      123      123
Impacted Files Coverage Δ
aiohttp/client_reqrep.py 97.35% <100%> (ø) ⬆️
aiohttp/connector.py 97.78% <100%> (+0.01%) ⬆️
tests/autobahn/client.py 95.74% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 706a4b8...dbb5886. Read the comment docs.

@asvetlov asvetlov merged commit b1f5afd into aio-libs:master Sep 16, 2017
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants