Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle session close during connection, KeyError: <aiohttp.connector.… #2282

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

fafhrd91
Copy link
Member

…_TransportPlaceholder> #2193

@codecov-io
Copy link

codecov-io commented Sep 20, 2017

Codecov Report

Merging #2282 into master will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2282      +/-   ##
==========================================
- Coverage   97.25%   97.24%   -0.02%     
==========================================
  Files          39       39              
  Lines        8091     8095       +4     
  Branches     1408     1410       +2     
==========================================
+ Hits         7869     7872       +3     
  Misses         97       97              
- Partials      125      126       +1
Impacted Files Coverage Δ
aiohttp/connector.py 97.6% <85.71%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1609acd...e404760. Read the comment docs.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@asvetlov
Copy link
Member

@fafhrd91 could you make a test for fixing partial coverage blame?
If not -- I could live with it.
Your code is safe, the change is obvious.
I'm talking just about raising coverage level a bit.
If we'll merge the PR as is -- nobody will write a test for the case, sure.

@fafhrd91 fafhrd91 merged commit 0b807a8 into master Sep 21, 2017
@fafhrd91 fafhrd91 deleted the fafhrd91/2193 branch September 21, 2017 16:25
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants