Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop py_35 constant #2363

Merged
merged 3 commits into from
Oct 20, 2017
Merged

Drop py_35 constant #2363

merged 3 commits into from
Oct 20, 2017

Conversation

asvetlov
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #2363 into master will increase coverage by 0.21%.
The diff coverage is 93.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2363      +/-   ##
==========================================
+ Coverage   96.96%   97.17%   +0.21%     
==========================================
  Files          39       39              
  Lines        8199     8180      -19     
  Branches     1437     1419      -18     
==========================================
- Hits         7950     7949       -1     
  Misses        101      101              
+ Partials      148      130      -18
Impacted Files Coverage Δ
aiohttp/web_urldispatcher.py 99.33% <100%> (+0.16%) ⬆️
aiohttp/client_reqrep.py 97.35% <100%> (+0.19%) ⬆️
aiohttp/test_utils.py 98.58% <100%> (+0.69%) ⬆️
aiohttp/streams.py 99.06% <100%> (+0.69%) ⬆️
aiohttp/helpers.py 97.16% <100%> (+0.22%) ⬆️
aiohttp/multipart.py 95.42% <77.27%> (+0.52%) ⬆️
examples/web_ws.py 94.84% <0%> (+0.37%) ⬆️
examples/client_ws.py 96.42% <0%> (+0.48%) ⬆️
tests/autobahn/client.py 94.92% <0%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9102c35...982ab0a. Read the comment docs.

@asvetlov asvetlov merged commit fb2ecef into master Oct 20, 2017
@asvetlov asvetlov deleted the drop-PY_35-constant branch October 20, 2017 21:41
asvetlov added a commit that referenced this pull request Nov 20, 2017
asvetlov added a commit that referenced this pull request Nov 20, 2017
* Fix #2363: Forbid synchronous context managers for ClientSession and test server/client.

* RuntimeError -> TypeError
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants