Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make multipart.boundary a str property #2589

Merged
merged 3 commits into from
Dec 5, 2017
Merged

Make multipart.boundary a str property #2589

merged 3 commits into from
Dec 5, 2017

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Dec 5, 2017

As discussed in #2545

@kxepal please review

@asvetlov asvetlov added this to the 3.0 milestone Dec 5, 2017
@asvetlov asvetlov requested a review from kxepal December 5, 2017 08:37
@codecov-io
Copy link

codecov-io commented Dec 5, 2017

Codecov Report

Merging #2589 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2589   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files          38       38           
  Lines        7305     7305           
  Branches     1263     1263           
=======================================
  Hits         7150     7150           
  Misses         51       51           
  Partials      104      104
Impacted Files Coverage Δ
aiohttp/multipart.py 95.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b69c8...ab5423b. Read the comment docs.

Copy link
Member

@kxepal kxepal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFGM. Ship it!

@asvetlov asvetlov merged commit 7c6f0bc into master Dec 5, 2017
@asvetlov asvetlov deleted the str-boundary branch December 5, 2017 12:56
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants