Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise InvalidStateError on two consequenced data_received() calls #2775

Merged
merged 2 commits into from
Feb 27, 2018

Conversation

asvetlov
Copy link
Member

Fix for #2773

@asvetlov asvetlov changed the base branch from master to 3.0 February 27, 2018 13:12
@codecov-io
Copy link

codecov-io commented Feb 27, 2018

Codecov Report

Merging #2775 into 3.0 will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #2775      +/-   ##
==========================================
+ Coverage   97.97%   98.02%   +0.05%     
==========================================
  Files          39       39              
  Lines        7341     7595     +254     
  Branches     1286     1369      +83     
==========================================
+ Hits         7192     7445     +253     
- Misses         47       49       +2     
+ Partials      102      101       -1
Impacted Files Coverage Δ
aiohttp/web_protocol.py 91.8% <100%> (+0.05%) ⬆️
aiohttp/web_urldispatcher.py 99.15% <0%> (-0.05%) ⬇️
aiohttp/http_writer.py 100% <0%> (ø) ⬆️
aiohttp/test_utils.py 98.92% <0%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5e9fd...1c541ab. Read the comment docs.

@asvetlov asvetlov merged commit 7b418fa into 3.0 Feb 27, 2018
@asvetlov asvetlov deleted the fix-invalid-state branch February 27, 2018 14:13
@pfreixes
Copy link
Contributor

Thanks for the fixing!

@asvetlov
Copy link
Member Author

Welcome!
Every major aiohttp release has such bugs.
Your changes was been made for good reason.
Unfortunately our test suite did not catch the problem.
Now everything is fine I hope.

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants