Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ClientResponse constructor #2820

Merged
merged 2 commits into from
Mar 10, 2018
Merged

Conversation

asvetlov
Copy link
Member

  1. Make logically required constructor arguments mandatory.
  2. Drop _post_init() method

@asvetlov asvetlov added this to the 3.1 milestone Mar 10, 2018
@codecov-io
Copy link

codecov-io commented Mar 10, 2018

Codecov Report

Merging #2820 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2820      +/-   ##
==========================================
- Coverage   97.99%   97.97%   -0.02%     
==========================================
  Files          39       39              
  Lines        7385     7375      -10     
  Branches     1297     1295       -2     
==========================================
- Hits         7237     7226      -11     
  Misses         47       47              
- Partials      101      102       +1
Impacted Files Coverage Δ
aiohttp/client_reqrep.py 97.24% <100%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3debc53...d8cc006. Read the comment docs.

@asvetlov asvetlov merged commit b42e0ce into master Mar 10, 2018
@asvetlov asvetlov deleted the client-response-refactoring branch March 10, 2018 09:15
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR client outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants