Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FAQ section Why is creating a ClientSession outside of an event loop dangerous? #3078

Merged
merged 2 commits into from
Jun 13, 2018
Merged

Add FAQ section Why is creating a ClientSession outside of an event loop dangerous? #3078

merged 2 commits into from
Jun 13, 2018

Conversation

asvetlov
Copy link
Member

Fix #3072

@asvetlov asvetlov mentioned this pull request Jun 13, 2018
Closed
socketpair
socketpair reviewed Jun 13, 2018
View reviewed changes
docs/faq.rst Outdated
-------------------------------------------------------------------

Short answer is: life-cycle of all asyncio objects should be shorter
than life-chicle of event loop.
Copy link
Contributor

@socketpair socketpair Jun 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chicle ?

https://en.wikipedia.org/wiki/Chicle

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks

@codecov-io
Copy link

codecov-io commented Jun 13, 2018 •
edited
Loading

Codecov Report

Merging #3078 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3078   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files          42       42           
  Lines        7750     7750           
  Branches     1349     1349           
=======================================
  Hits         7604     7604           
  Misses         51       51           
  Partials       95       95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f644a8c...709aa5e. Read the comment docs.

@asvetlov asvetlov merged commit ce5f041 into master Jun 13, 2018
@asvetlov asvetlov deleted the faq branch June 13, 2018 15:08
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@socketpair socketpair socketpair left review comments

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is creating a ClientSession outside of an event loop "dangerous"?
4 participants
@asvetlov @codecov-io @webknjaz @socketpair