Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StreamResponse equality #3107

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Fix StreamResponse equality #3107

merged 1 commit into from
Jun 26, 2018

Conversation

NotSqrt
Copy link
Contributor

@NotSqrt NotSqrt commented Jun 25, 2018

What do these changes do?

StreamResponse as subclass of MutableMapping introduced equality defined as return dict(self.items()) == dict(other.items()).
Now, it is back to identity of addresses.

Are there changes in behavior for the user?

Back to the behaviour of pre-3.0 aiohttp version.

Related issue number

Fixes #3100

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes (no specific mention of __eq__ in the docs)
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Jun 25, 2018

Codecov Report

Merging #3107 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3107      +/-   ##
==========================================
+ Coverage   98.05%   98.06%   +<.01%     
==========================================
  Files          43       43              
  Lines        7834     7836       +2     
  Branches     1353     1353              
==========================================
+ Hits         7682     7684       +2     
  Misses         56       56              
  Partials       96       96
Impacted Files Coverage Δ
aiohttp/web_response.py 98.19% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b8d7a...701cf4e. Read the comment docs.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@asvetlov asvetlov merged commit 3a65252 into aio-libs:master Jun 26, 2018
@asvetlov
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StreamResponse instances are all equal
3 participants