Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractRouteDef is importable from the web module (#3183) #3188

Merged
merged 1 commit into from
Aug 12, 2018
Merged

AbstractRouteDef is importable from the web module (#3183) #3188

merged 1 commit into from
Aug 12, 2018

Conversation

Maillol
Copy link
Contributor

@Maillol Maillol commented Aug 12, 2018

Add AbstractRouteDef to the __all__ tuple in order to allow importation from web module

According to the documentation, the user can use from aiohttp.web import AbstractRouteDef instead of from aiohttp.web_routedef import AbstractRouteDef

Related issue number

#3183

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Aug 12, 2018

Codecov Report

Merging #3188 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3188      +/-   ##
==========================================
- Coverage   98.11%   98.07%   -0.04%     
==========================================
  Files          43       43              
  Lines        7853     7853              
  Branches     1354     1354              
==========================================
- Hits         7705     7702       -3     
- Misses         57       59       +2     
- Partials       91       92       +1
Impacted Files Coverage Δ
aiohttp/web_routedef.py 100% <100%> (ø) ⬆️
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/client_reqrep.py 97.47% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb78691...2437003. Read the comment docs.

@asvetlov asvetlov merged commit 2a165db into aio-libs:master Aug 12, 2018
@asvetlov
Copy link
Member

Thanks!

@Maillol Maillol deleted the AbstractRouteDef-is-importable-from-web-module branch August 16, 2018 06:24
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants