-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bracket IPv6 addresses in the HOST header (#3304) #3305
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3305 +/- ##
=========================================
- Coverage 98.07% 98% -0.08%
=========================================
Files 43 43
Lines 8001 8020 +19
Branches 1354 1354
=========================================
+ Hits 7847 7860 +13
- Misses 63 66 +3
- Partials 91 94 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a news fragment as stated in the checklist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pollydrag your PR is perfect but please add a change-note
(@pollydrag this means that you need to add a file to |
And feel free to add yourself to the contributors list! |
thanks! |
@@ -162,6 +162,7 @@ Paulius Šileikis | |||
Paulus Schoutsen | |||
Pavel Kamaev | |||
Pawel Miech | |||
Pavel Polyakov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is out of order. T U V W X Y Z
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Fixed by f6b81b3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to lint that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think linux sort
can be used for this.
For example, the check might look like LC_ALL=C sort -c CONTRIBUTORS.txt
But first you need to make it sorted: LC_ALL=C sort -o CONTRIBUTORS.txt CONTRIBUTORS.txt
First line may be changed as - Contributors
for keep sorting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't care too much -- but if somebody want to make a PR for this you are welcome
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
What do these changes do?
Bracket IPv6 addresses in the HOST header
Are there changes in behavior for the user?
No changes
Related issue number
#3304
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.