Use timestamp instead of datetime to achieve faster cookie expiration in CookieJar

[Rongronggg9]

What do these changes do?

Use timestamp instead of datetime to achieve faster cookie expiration in CookieJar

Are there changes in behavior for the user?

No.

Related issue number

#7583
#7819 (comment)

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[Rongronggg9]

The test failure is Windows-specific. See also https://stackoverflow.com/questions/46133223/maximum-value-of-timestamp

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (536c80e) 97.41% compared to head (de684c8) 97.40%.
Report is 8 commits behind head on master.

Files	Patch %	Lines
aiohttp/cookiejar.py	85.71%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7824      +/-   ##
==========================================
- Coverage   97.41%   97.40%   -0.02%     
==========================================
  Files         106      106              
  Lines       32115    32142      +27     
  Branches     3728     3738      +10     
==========================================
+ Hits        31285    31307      +22     
- Misses        627      631       +4     
- Partials      203      204       +1     

Flag	Coverage Δ
CI-GHA	97.31% <88.00%> (-0.02%)	⬇️
OS-Linux	96.99% <84.00%> (-0.02%)	⬇️
OS-Windows	95.48% <88.00%> (-0.02%)	⬇️
OS-macOS	96.67% <84.00%> (-0.01%)	⬇️
Py-3.10.11	95.41% <88.00%> (-0.02%)	⬇️
Py-3.10.13	96.84% <84.00%> (-0.03%)	⬇️
Py-3.11.6	96.50% <84.00%> (-0.03%)	⬇️
Py-3.12.0	96.57% <84.00%> (?)
Py-3.8.10	95.38% <88.00%> (-0.02%)	⬇️
Py-3.8.18	96.77% <84.00%> (-0.02%)	⬇️
Py-3.9.13	95.38% <88.00%> (-0.02%)	⬇️
Py-3.9.18	96.81% <84.00%> (-0.02%)	⬇️
Py-pypy7.3.13	96.27% <84.00%> (-0.03%)	⬇️
VM-macos	96.67% <84.00%> (-0.01%)	⬇️
VM-ubuntu	96.99% <84.00%> (-0.02%)	⬇️
VM-windows	95.48% <88.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bdraco]

import timeit
from http import cookies

from yarl import URL

from aiohttp import CookieJar


def filter_large_cookie_jar():
    """Filter out large cookies from the cookie jar."""
    jar = CookieJar()
    c = cookies.SimpleCookie()
    domain_url = URL("http://maxagetest.com/")
    other_url = URL("http://otherurl.com/")

    for i in range(5000):
        cookie_name = f"max-age-cookie{i}"
        c[cookie_name] = "any"
        c[cookie_name]["max-age"] = 60
        c[cookie_name]["domain"] = "maxagetest.com"
    jar.update_cookies(c, domain_url)
    assert len(jar) == 5000
    assert len(jar.filter_cookies(domain_url)) == 5000
    assert len(jar.filter_cookies(other_url)) == 0

    filter_domain = timeit.timeit(lambda: jar.filter_cookies(domain_url), number=1000)
    filter_other_domain = timeit.timeit(
        lambda: jar.filter_cookies(other_url), number=1000
    )
    print(f"filter_domain: {filter_domain}")
    print(f"filter_other_domain: {filter_other_domain}")


filter_large_cookie_jar()

Basic benchmark to test against (can probably be improved a bit), although I don't think this PR will affect it very much

[patchback]

Backport to 3.9: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 8ae650b on top of patchback/backports/3.9/8ae650bee4add9f131d49b96a0a150311ea58cd1/pr-7824

Backporting merged PR #7824 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.9/8ae650bee4add9f131d49b96a0a150311ea58cd1/pr-7824 upstream/3.9

4. Now, cherry-pick PR Use timestamp instead of datetime to achieve faster cookie expiration in CookieJar #7824 contents into that branch:

   $ git cherry-pick -x 8ae650bee4add9f131d49b96a0a150311ea58cd1

   If it'll yell at you with something like fatal: Commit 8ae650bee4add9f131d49b96a0a150311ea58cd1 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 8ae650bee4add9f131d49b96a0a150311ea58cd1

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Use timestamp instead of datetime to achieve faster cookie expiration in CookieJar #7824 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.9/8ae650bee4add9f131d49b96a0a150311ea58cd1/pr-7824

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[Dreamsorcerer]

#7837