Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timestamp instead of datetime to achieve faster cookie expiration… #7837

Conversation

Dreamsorcerer
Copy link
Member

(cherry picked from commit 8ae650b)

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cb94533) 97.35% compared to head (a1ad723) 97.35%.
Report is 3 commits behind head on 3.9.

Files Patch % Lines
aiohttp/cookiejar.py 88.00% 2 Missing and 1 partial ⚠️
aiohttp/resolver.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              3.9    #7837      +/-   ##
==========================================
- Coverage   97.35%   97.35%   -0.01%     
==========================================
  Files         107      107              
  Lines       32357    32357              
  Branches     3836     3838       +2     
==========================================
- Hits        31501    31500       -1     
  Misses        652      652              
- Partials      204      205       +1     
Flag Coverage Δ
CI-GHA 97.26% <91.11%> (-0.01%) ⬇️
OS-Linux 96.95% <88.88%> (-0.01%) ⬇️
OS-Windows 94.49% <91.11%> (-0.01%) ⬇️
OS-macOS 96.61% <88.88%> (-0.01%) ⬇️
Py-3.10.11 94.40% <91.11%> (-0.01%) ⬇️
Py-3.10.13 96.78% <88.88%> (-0.01%) ⬇️
Py-3.11.6 96.45% <88.88%> (-0.01%) ⬇️
Py-3.12.0 96.50% <88.88%> (?)
Py-3.8.10 94.37% <91.11%> (-0.01%) ⬇️
Py-3.8.18 96.71% <88.88%> (-0.01%) ⬇️
Py-3.9.13 94.38% <91.11%> (-0.01%) ⬇️
Py-3.9.18 96.76% <88.88%> (-0.01%) ⬇️
Py-pypy7.3.13 96.21% <88.88%> (-0.01%) ⬇️
VM-macos 96.61% <88.88%> (-0.01%) ⬇️
VM-ubuntu 96.95% <88.88%> (-0.01%) ⬇️
VM-windows 94.49% <91.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit e07a1bd into 3.9 Nov 14, 2023
24 of 29 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.9/8ae650bee4add9f131d49b96a0a150311ea58cd1/pr-7824 branch November 14, 2023 12:29
xiangxli pushed a commit to xiangxli/aiohttp that referenced this pull request Dec 4, 2023
aio-libs#7837)

(cherry picked from commit 8ae650b)

Co-authored-by: Rongrong <i@rong.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants