-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement happy eyeballs (RFC 8305) #7954
Conversation
functional tests seem to be ok Anything that does this will fail since
|
I'm still doing testing with this, and I think its ready to move to wider production testing. I'm going to spend a few cycles on |
So far so good on production 3.9+backported. Doing performance testing now |
performance looks good. All the time is nearly
submitted python/cpython#112989 and will PR cpython. This is not a new problem |
Still testing out great this morning |
I think this is good to merge at this point, but I'm slow rolling it because ESPHome is currently in beta which also uses the |
ESPHome is releasing today with the new lib, HA is doing beta next week with it |
This change in esphome release seems to be going swimmingly. Next week we get beta feedback on it in aiohomekit from Home Assistant |
The changes in aiohomekit seem to be going well in the HA beta. |
Ha beta has been without issues in this area. The full release happens tomorrow. As long as everything goes smoothly, I'll merge this shortly after |
HA release shipped today. No issues so far. All looking good |
Everything seems solid with the HA release related to this. That's the last hurdle. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c4ec3f1 on top of patchback/backports/3.10/c4ec3f130af3a53040b883aa2fab06fd215f9088/pr-7954 Backporting merged PR #7954 into master
🤖 @patchback |
(cherry picked from commit c4ec3f1)
What do these changes do?
Implements Happy Eyeballs support (https://datatracker.ietf.org/doc/html/rfc8305)
Are there changes in behavior for the user?
Dual stack connections where IPv6 is not working should now be successful.
Related issue number
fixes #4451
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.--
TODO
happy_eyeballs_delay
andinterleave
function the same as cpython but we should point that out, and how to disablehappy_eyeballs_delay
by setting it toNone
)This PR is a first step as I need to make sure this library works for the other projects as well. Its likely to sit for a bit while I test the library with all the projects that need it so there aren't any need to do breaking changes before all the other projects start consuming it:
--