gh-112989: asyncio: Reduce overhead to connect sockets with SelectorEventLoop #112991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectorEventLoop _ensure_fd_no_transport had a KeyError in the success path
11 tasks
bdraco
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
|
Thanks! |
|
Is a backport needed or shall we close the issue? #112989 |
|
Closed the issue, sorry I forgot to do that. No backport needed unless someone has a high volume of socket connection and requests it. For Home Assistant we ship our own python w/patches so its not urgent for us. |
bdraco
added a commit
to home-assistant/docker-base
that referenced
this pull request
Dec 16, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ectorEventLoop (python#112991) _ensure_fd_no_transport had a KeyError in the success path
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ectorEventLoop (python#112991) _ensure_fd_no_transport had a KeyError in the success path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_ensure_fd_no_transporthad aKeyErrorin the success path. It can be replaced with a simpledict.getThe performance profile is similar to previous discussion #106527 (comment)