Fix command line arg parsing; issue #797 #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -349,7 +349,7 @@ def main(argv): | |||
| type=int, | |||
| default="8080" | |||
| ) | |||
| args, extra_args = arg_parser.parse_known_args(argv) | |||
| args, extra_args = arg_parser.parse_known_args(argv[1:]) | |||
There was a problem hiding this comment.
Maybe better to pass sys.argv[1:] into main() call?
There was a problem hiding this comment.
I don't think it really matters, either is fine. Change it if you like.
There was a problem hiding this comment.
Please change. I have a guts feeling that accepting sys.argv[1:] is better.
Also I saw the similar approach in past a veral times.
asvetlov
added a commit
that referenced
this pull request
Feb 27, 2016
Fix command line arg parsing; issue #797
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #797