Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] Handle 403 and 404 issues in FileResponse class (#8538) #8539

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

steverep
Copy link
Member

(cherry picked from commit 4f834b6)

What do these changes do?

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

(cherry picked from commit 4f834b6)

Co-authored-by: Steve Repsher <steverep@users.noreply.github.com>
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (3baa6de) to head (9da180c).
Report is 199 commits behind head on 3.10.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #8539   +/-   ##
=======================================
  Coverage   97.56%   97.57%           
=======================================
  Files         108      108           
  Lines       33520    33582   +62     
  Branches     4027     4029    +2     
=======================================
+ Hits        32704    32767   +63     
  Misses        594      594           
+ Partials      222      221    -1     
Flag Coverage Δ
CI-GHA 97.47% <98.80%> (+<0.01%) ⬆️
OS-Linux 97.14% <97.61%> (+<0.01%) ⬆️
OS-Windows 94.69% <77.38%> (-0.05%) ⬇️
OS-macOS 96.81% <97.61%> (+<0.01%) ⬆️
Py-3.10.11 96.92% <98.80%> (+<0.01%) ⬆️
Py-3.10.14 96.87% <97.61%> (+<0.01%) ⬆️
Py-3.11.9 97.11% <98.80%> (+<0.01%) ⬆️
Py-3.12.4 97.23% <98.80%> (+<0.01%) ⬆️
Py-3.8.10 94.42% <77.38%> (-0.05%) ⬇️
Py-3.8.18 96.77% <97.61%> (+<0.01%) ⬆️
Py-3.9.13 96.91% <98.80%> (+<0.01%) ⬆️
Py-3.9.19 96.88% <97.61%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.44% <97.61%> (+<0.01%) ⬆️
VM-macos 96.81% <97.61%> (+<0.01%) ⬆️
VM-ubuntu 97.14% <97.61%> (+<0.01%) ⬆️
VM-windows 94.69% <77.38%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit df57b9f into aio-libs:3.10 Jul 26, 2024
28 of 29 checks passed
@steverep steverep deleted the backport-4f834b6-3.10 branch July 27, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants