-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid creation of tuples to create new URL
objects
#1398
Conversation
CodSpeed Performance ReportMerging #1398 will not alter performanceComparing Summary
|
URL
objects
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1398 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 31 31
Lines 5748 5752 +4
Branches 342 342
=======================================
+ Hits 5521 5525 +4
Misses 201 201
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Its ~5% faster. Not enough for codspeed's margin of error |
Instead of creating a
tuple
and passing it tocls._from_tup
, pass the parts tocls._from_parts
, and to avoid packing and unpacking the tuple. The arguments still have to be unpacked but its a bit faster.