Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 compatibility #881

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Python 3.12 compatibility #881

merged 4 commits into from
Jun 7, 2023

Conversation

mjpieters
Copy link
Contributor

Add 3.12 to the CI test matrix and ensure things work.

  • Ignore depr warnings inside pytest on 3.12
  • Upgrade cython to 3.0.0b1

Fixes #829

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #881 (90f6431) into master (1d03a63) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #881   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files           4        4           
  Lines         772      772           
  Branches      219      219           
=======================================
  Hits          770      770           
  Misses          2        2           
Flag Coverage Δ
unit 99.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mjpieters
Copy link
Contributor Author

mjpieters commented Jun 6, 2023

Note that the 3.12 test suite now fails because 3.12.0b1 includes an updated urllib.parse version which performs IP address validation; the same changes will be part of Python 3.11.4 (due to be released very very soon). This is a separate issue, see #876, which should be tackled in a separate PR.

Until 3.12 final is released, the tests are allowed to fail.
These warnings otherwise would abort the test suite. See
pytest-dev/pytest#10977.
This release outputs C files compatible with Python 3.12.
@mjpieters mjpieters enabled auto-merge (squash) June 7, 2023 12:51
@mjpieters mjpieters merged commit 15f2455 into master Jun 7, 2023
@mjpieters mjpieters deleted the py312_fixes branch June 7, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12: ‘PyLongObject’ {aka ‘struct _longobject’} has no member named ‘ob_digit’
2 participants