-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow support for Python 3.12 #146
Conversation
The CI run at least shows
|
@Tenzer, we can drop 3.7 support. It was already removed from the Thumbor main project. |
I got a bit further with this now but hit a couple of other roadblocks:
|
Python 3.12 was released on 2023-10-02 and this extension should work in the new version without any code changes. The configuration for the project however doesn't allow it to be installed on Python 3.12, but this fixes that.
I have rebased the changes and dropped Python 3.8 support in order to get the updated Scipy that works with Python 3.12. Tests are successful for me now. |
Pull Request Test Coverage Report for Build 7086600018
💛 - Coveralls |
@Tenzer , this might be an issue, since Thumbor still supports Python3.8. |
@Tenzer, you can pin Python 3.8 to scipy 1.10.1 and the others with a newer version. |
This still follows the version ranges specified inside `pyproject.toml` but means we get version of the dependencies that work with Python 3.12.
This required bumping the minimum Python version 3.8.1 since that's what flake8 requires as the minimum requirement: PyCQA/flake8#1741.
This is in order to maintain support for Python 3.8 while still being able to use more recent versions of the dependencies that incorporate Python 3.12 support.
Good idea. I have kept the version range the same for Python 3.8 support for now, but we can bump that if you want. Python 3.9+ are using the version of NumPy and SciPy that has 3.12 support. |
Thanks for the contribution @Tenzer |
You're welcome! |
Python 3.12 was released on 2023-10-02, and this extension should work in the new version without any code changes. The configuration for the project, however, doesn't allow it to be installed on Python 3.12, but this fixes that.
Note: This doesn't remove support for Python 3.7 even though that has reached end-of-life. Let me know if you'd like me to remove support for that here as well.