feat(AIP-134): Make update_mask field must be optional
#1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-scripniciuc
approved these changes
Mar 15, 2024
WontonSam
approved these changes
Apr 14, 2024
noahdietz
approved these changes
Apr 15, 2024
noahdietz
requested review from
jskeet
and removed request for
loudej and
bgrant0607
|
@jskeet now that Andrei's stamp doesn't count anymore, can you review/Approve this PR? Thanks |
|
Will need to have a think about this - will look again tomorrow. |
jskeet
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldBehavior of
update_maskfields now must always be optional. This makes it clearer for clients to opt-in for implied update_mask behaviour.