Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AIP-134): update_mask must be OPTIONAL #1394

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

noahdietz
Copy link
Collaborator

Implements enforcement for AIP-134 change aip-dev/google.aip.dev#1327.

Previously, update_mask could be either OPTIONAL or REQUIRED. Now it can and must only be OPTIONAL.

Adds locations.FieldBehavior helper for annotation source code location, and refactors one other place to use it.

@noahdietz noahdietz requested a review from a team as a code owner May 29, 2024 22:16
@noahdietz noahdietz requested a review from alin04 June 11, 2024 21:29
@noahdietz noahdietz requested review from jskeet and removed request for alin04 July 3, 2024 16:53
@noahdietz noahdietz requested a review from jskeet July 10, 2024 15:51
@noahdietz noahdietz merged commit 9fc0d05 into googleapis:main Jul 10, 2024
6 checks passed
@noahdietz noahdietz deleted the optional-update-mask branch July 10, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants