[lambda][rule] some s3 optimizations #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinbyers
suggested changes
Apr 28, 2017
| yield line.rstrip() | ||
|
|
||
| # remove the file | ||
| os.remove(downloaded_s3_object) |
There was a problem hiding this comment.
This doesn't work as expected in Lambda - you have to truncate the file first to avoid using all of the disk space
There was a problem hiding this comment.
Hmm that's strange and doesn't make much sense, but okay. I will add the truncate back.
There was a problem hiding this comment.
Yeah, Jack and I both independently observed the phenomenon. os.remove is really os.unlink, and presumably Lambda's version of unlinking is not the same as a traditional OS
| Args: | ||
| downloaded_s3_object (string): A full path to the downloaded file. | ||
|
|
||
| Returns: |
ryandeivert
force-pushed
the
ryandeivert-s3-optimizations
branch
2 times, most recently
from
140b654 to
d3611db
Compare
|
|
…ack a truncate call due to aws bug
ryandeivert
force-pushed
the
ryandeivert-s3-optimizations
branch
from
d3611db to
ce14db3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to @airbnb/streamalert-maintainers
size: small
changes