fix(text, shape): Hide generated text element from assitive technolog…

…ies (#1551)
airbnb · Aug 3, 2022 · a027ca6 · a027ca6
1 parent c8dda52
commit a027ca6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/packages/visx-shape/src/util/getOrCreateMeasurementElement.ts b/packages/visx-shape/src/util/getOrCreateMeasurementElement.ts
@@ -6,7 +6,9 @@ export default function getOrCreateMeasurementElement(elementId: string) {
   // create a single path element if not done already
   if (!pathElement) {
     const svg = document.createElementNS(SVG_NAMESPACE_URL, 'svg');
+
     // not visible
+    svg.setAttribute('aria-hidden', 'true');
     svg.style.opacity = '0';
     svg.style.width = '0';
     svg.style.height = '0';

diff --git a/packages/visx-text/src/util/getStringWidth.ts b/packages/visx-text/src/util/getStringWidth.ts
@@ -8,6 +8,7 @@ function getStringWidth(str: string, style?: object) {
     let textEl = document.getElementById(MEASUREMENT_ELEMENT_ID) as SVGTextElement | null;
     if (!textEl) {
       const svg = document.createElementNS('http://www.w3.org/2000/svg', 'svg');
+      svg.setAttribute('aria-hidden', 'true');
       svg.style.width = '0';
       svg.style.height = '0';
       svg.style.position = 'absolute';