fix(text, shape): Hide generated text element from assistive technologies #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashoggard
changed the title
williaster
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
lgtm, thanks so much @thomashoggard for the bug report and fix! 🙏
will get it merged/released once CI finishes.
|
🎉 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1544
Currently the generated svg used to calculate text and shape size are being read by assitive technologies like screen readers. This PR hides the generated element so it's now hidden for both screen reader and visual users.
I tested using the demo app and verified the attribute was being added within Chrome dev tools.
