-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brush: "An update was scheduled from inside an update function" warning when using "resetOnEnd" #1465
Labels
Comments
I'm experiencing the same issue |
I also am seeing this same error. Any insight as to the cause/solution? |
I am also facing the same issue. Any updates on this? |
Also facing the same issue. Wondering if anyone has got a solution. |
Same here, anyone managed to fix it? |
Same issue here, any update about it? |
dsdevgit
added a commit
to dsdevgit/visx
that referenced
this issue
Dec 15, 2023
williaster
pushed a commit
that referenced
this issue
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
When using resetOnEnd in a Brush and after there's a brush end event, the following React warning is thrown
Warning: An update (setState, replaceState, or forceUpdate) was scheduled from inside an update function. Update functions should be pure, with zero side-effects. Consider using componentDidUpdate or a callback.
This error is also reproducible if instead of using "resetOnEnd" the brush reference is used inside an "onBrushEnd" to call directly the "reset()" function
Steps to reproduce
I created this demo which basically consists of the Brush example with the "resetOnEnd" attribute.
Attachments
Screen.Recording.2022-04-05.at.09.04.23.mov
The text was updated successfully, but these errors were encountered: