fix(brush): fix issue 'update was scheduled' warning on resetOnEnd #1465

[dsdevgit]

🐛 Bug Fix

• Fixed issue #1465

React warns 'An update was scheduled from inside an update function' in case we set resetOnEnd = true or if we call the reset() method imperatively.

The problem:

In short we call setState method inside of updater function of another setState

this.setState(() => {
    // ...
    //...
    this.setState(() => {
        //...
    })
})

In the BaseBrush.ts

1. updateBrush() calls the setState() method
2. handleDragEnd() or handleWindowPointerUp() call the updateBrush() with updater function contains reset()
3. reset() also calls updateBrush()

The Solution:

1. Move brush "idle" state object to getIdleState() (state of brush if it is not in use)
2. Avoid calling the setState method again by modifying the state passed in the first call (if resetOnEnd=true we set 'idle' state from getIdleState())
3. For reset() method, we just call updateBrush() with 'idle' state

[williaster]

hey @dsdevgit thanks for such a great write-up and PR for a long-outstanding bug ❤️ 🙏

this lgtm, will get it released shortly.

[github-actions]

🎉 This PR is included in version v3.6.1 of the packages modified 🎉

[dsdevgit]

Many thanks @williaster