Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visx/threshold not included in visx/visx #1556

Closed
sgehrman opened this issue Aug 16, 2022 · 1 comment · Fixed by #1563
Closed

visx/threshold not included in visx/visx #1556

sgehrman opened this issue Aug 16, 2022 · 1 comment · Fixed by #1563
Labels
🐣 beginner friendly 🐛 bug 👋 help wanted @visx/threshold @visx/visx

Comments

@sgehrman
Copy link 

"@visx/visx": "^2.12.2",

// had to include this separately
"@visx/threshold": "^2.12.2",
@williaster
Copy link
Collaborator

thanks for the report @sgehrman 🙏 that should be an easy fix if someone is interested.

DantrazTrev added a commit to DantrazTrev/visx that referenced this issue Sep 3, 2022
@DantrazTrev
Include visx/threshold in visx/visx
986f5ea 
Fixes airbnb#1556
@DantrazTrev DantrazTrev mentioned this issue Sep 3, 2022
Merged
williaster pushed a commit that referenced this issue Sep 6, 2022
@DantrazTrev
Include visx/threshold in visx/visx (#1563)
6806c09 
* Include visx/threshold in visx/visx

Fixes #1556

* Update package.json

* Exported Threshold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐣 beginner friendly 🐛 bug 👋 help wanted @visx/threshold @visx/visx
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include visx/threshold in visx/visx DantrazTrev/visx
2 participants
@sgehrman @williaster