Include visx/threshold in visx/visx #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
reviewed
Sep 6, 2022
There was a problem hiding this comment.
Hey @DantrazTrev 👋 thanks for the fix/contribution!
The package.json looks good, but will also need to export the contents of the package from the index.ts file. after that we should be good to land 🚀
|
Hei @williaster apologies didn't look that way . It's fixed thanks for pointing out |
williaster
approved these changes
Sep 6, 2022
|
🎉 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1556
Added visx/threshold in visx/visx