-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bar with one side rounded rectangle #529
Comments
@sladomic any chance I could get a snippet of how you're getting the rect/path map to get just one side bit the border rounded ? |
hey @rafaeldsousa. I just implemented it the way described in the Medium post above. But I never opened a pull request because right after that everything got rewritten to typescript and I'd have to rewrite it and the tests again. |
Thanks @sladomic. Yep, I've realised that the article was the way to go and did the same. (: |
I wonder if this could be a new component called Happy to review any PRs and get this in if anyone is interested in adding it so all could benefit 😄 |
The current Bar uses an SVG rect and therefore only supports two sides and four sides rounded rectangles (with the rx and ry attributes).
To have a one side rounded rectangle we have to use another SVG shape like path https://medium.com/@dennismphil/one-side-rounded-rectangle-using-svg-fb31cf318d90
The implementation would break the API, since the path shape has only one dedicated attribute "d".
There are several options of how to implement:
We already use option 1 and would like to know, if we can open a pull request for it or have to change something in advance?
The text was updated successfully, but these errors were encountered: