Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vx-shape): add BarRounded shape #774

Merged
merged 3 commits into from
Aug 2, 2020
Merged

feat(vx-shape): add BarRounded shape #774

merged 3 commits into from
Aug 2, 2020

Conversation

hshoff
Copy link
Member

@hshoff hshoff commented Aug 2, 2020

fixes: #529

🚀 Enhancements

  • [shape] add <BarRounded /> shape

🏋️ Tests

  • [shape] add bar rounded tests

🎨 Usage

// apply 6px radius to top left corner and top right corner
<BarRounded top radius={6} />

// apply 6px radius to top left corner and bottom left corner
<BarRounded left radius={6} />

// apply 6px radius to top right corner and bottom right corner
<BarRounded right radius={6} />

// apply 6px radius to bottom left corner and bottom right corner
<BarRounded bottom radius={6} />

// only apply 6px radius to top left corner
<BarRounded topLeft radius={6} />

// only apply 6px radius to top right corner
<BarRounded topRight radius={6} />

// only apply 6px radius to bottom right corner
<BarRounded bottomRight radius={6} />

// only apply 6px radius to bottom Left corner
<BarRounded bottomLeft radius={6} />

// apply 6px radius to every corner
<BarRounded all radius={6} />

// apply 6px radius to every corner except topRight
<BarRounded left bottom radius={6} />

Can be used in place of <Bar /> in <BarGroup /> and <BarStack /> using the function as children API.

@hshoff hshoff added this to the 0.0.199 milestone Aug 2, 2020
Copy link
Collaborator

@kristw kristw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a nice addition 👍

packages/vx-shape/src/shapes/BarRounded.tsx Outdated Show resolved Hide resolved
@hshoff hshoff merged commit 5d1dbcf into master Aug 2, 2020
@hshoff hshoff deleted the harry-round-rect branch August 2, 2020 15:35
@williaster
Copy link
Collaborator

sorry I'm slow to review, this will be a great add!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bar with one side rounded rectangle
3 participants