Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(seygai): publish the customized visx #1210

Closed
wants to merge 1 commit into from

Conversation

hsunpei
Copy link
Contributor

@hsunpei hsunpei commented May 13, 2021

Purpose

react-spring's version of visx is v8.

In order to use v9, we create the fork of visx before there would be an upgrade.

@hsunpei hsunpei closed this May 13, 2021
@hsunpei hsunpei deleted the feat/seygai-build branch May 13, 2021 17:29
@hsunpei
Copy link
Contributor Author

hsunpei commented May 13, 2021

I am really sorry about creating the PR in the wrong place on a mistake.

@hsunpei hsunpei restored the feat/seygai-build branch May 13, 2021 17:35
@williaster
Copy link
Collaborator

hey @garfieldduck no worries! FYI, I'm definitely open to moving to v9 and then we can just publish a 2.0 for @visx/*. So if you'd like to help out with that upgrade you can do it as a PR in the primary repo and I'm happy to review it! @visx/react-spring and @visx/xychart should be the relevant packages to update.

@hsunpei
Copy link
Contributor Author

hsunpei commented May 15, 2021

Thanks so much, @williaster 😊!
I submitted a PR to upgrade react-spring to v9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants