deps: upgrade react-spring to v9 #1218
Conversation
packages/visx-demo/yarn.lock
Outdated
| @@ -0,0 +1,7675 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
since visx uses yarn workspaces, we have only committed the yarn.lock file in the repo root directory. so I think if you remove this file we can just rely on the updated root yarn.lock you've updated.
There was a problem hiding this comment.
Yes, definitely! I didn't notice that I added this file accidentally.
| animateXOrY: horizontal ? 'x' : 'y', | ||
| animationTrajectory, | ||
| }), | ||
| keys: (tick: { value: any }) => `${tick.value}`, |
There was a problem hiding this comment.
wonder if we could do something like this instead of using any
// add this to the import above
import { ComputedTick, ... } from '@visx/axis/lib/types';
// in hook
keys: (tick: ComputedTick<Scale>) => `${tick.value}`,There was a problem hiding this comment.
Great point! I'll change it.
| ) => { | ||
| const tickLabelProps = allTickLabelProps[index] ?? allTickLabelProps[0] ?? {}; | ||
| return item == null || key == null ? null : ( | ||
| {animatedTicks(({ fromX, toX, fromY, toY, opacity }, item, { key }, index) => { |
There was a problem hiding this comment.
nit: im getting a ts warning -> Property 'fromX' does not exist on type '{}'.ts(2339) for { fromX, toX, fromY, toY, opacity },
might be good to keep the @ts-ignore if no explicit type is defined
// @ts-ignore react-spring types only include CSSProperties
There was a problem hiding this comment.
It may be caused by the type inference issue of 9.1.2.
After running yarn, it picks up9.1.2 automatically instead of 9.0.0-rc.3.
But I think it's not nice to stick to 9.0.0-rc.3 instead of using ^9.0.0-rc.3 in peer dependencies, so I think putting @ts-ignore here is indeed a good idea.
There was a problem hiding this comment.
looks like this is still broken in 9.2.0 so maybe @ts-ignore is the way to go 😢
|
Hey @garfieldduck sorry for the delay on this PR, we've been trying to figure out how to stage this alongside the Do you want to try bumping up to |
|
Superseded by #1277 |
|
Hey @williaster, thanks so much for the upgrade 🎉!!! |
🏠 Internal
@visx/react-springis currently dependent onreact-springv8.While
react-springintroduces several breaking changes in v9, and thus making@visx/react-springincompatible with projects using the latest version ofreact-spring.This PR upgrades the
react-springto v9.Note
There are still some typing issues in the formal release of v9 which prevents inferring the type of
useTransitioncorrectly.To avoid this issue, this PR uses
9.0.0-rc.3as the peer dependency instead of9.1.2.