Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "new(axis): add shapeRendering prop to Axis" #1808

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

williaster
Copy link
Collaborator

@williaster williaster commented Mar 8, 2024

Reverts #1739 . this actually made the tick line rendering more blurry as it overrode #840

image

by removing this, you can still set it via axisLineClassName, and you can set it for tick lines via tickLineProps

cc @Lonami

Copy link

github-actions bot commented Mar 8, 2024

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
visx-axis -0.4% 21.27 KB 21.35 KB 25.81 KB 25.89 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "visx-annotation": {
    "esm": 31002,
    "lib": 43431
  },
  "visx-axis": {
    "esm": 21861,
    "lib": 26512
  },
  "visx-bounds": {
    "esm": 2948,
    "lib": 3371
  },
  "visx-brush": {
    "esm": 55627,
    "lib": 60219
  },
  "visx-chord": {
    "esm": 3478,
    "lib": 4691
  },
  "visx-clip-path": {
    "esm": 4524,
    "lib": 6062
  },
  "visx-curve": {
    "esm": 323,
    "lib": 1462
  },
  "visx-delaunay": {
    "esm": 2599,
    "lib": 3428
  },
  "visx-demo": {
    "esm": 0,
    "lib": 36731
  },
  "visx-drag": {
    "esm": 12756,
    "lib": 14402
  },
  "visx-event": {
    "esm": 3878,
    "lib": 5194
  },
  "visx-geo": {
    "esm": 13662,
    "lib": 16903
  },
  "visx-glyph": {
    "esm": 15177,
    "lib": 19992
  },
  "visx-gradient": {
    "esm": 18202,
    "lib": 22847
  },
  "visx-grid": {
    "esm": 18982,
    "lib": 22665
  },
  "visx-group": {
    "esm": 1648,
    "lib": 2267
  },
  "visx-heatmap": {
    "esm": 7394,
    "lib": 8731
  },
  "visx-hierarchy": {
    "esm": 12093,
    "lib": 17910
  },
  "visx-legend": {
    "esm": 26944,
    "lib": 34024
  },
  "visx-marker": {
    "esm": 9152,
    "lib": 11350
  },
  "visx-mock-data": {
    "esm": 326040,
    "lib": 329480
  },
  "visx-network": {
    "esm": 4674,
    "lib": 6809
  },
  "visx-pattern": {
    "esm": 11689,
    "lib": 15763
  },
  "visx-point": {
    "esm": 1003,
    "lib": 1818
  },
  "visx-react-spring": {
    "esm": 14040,
    "lib": 17765
  },
  "visx-responsive": {
    "esm": 12972,
    "lib": 16175
  },
  "visx-scale": {
    "esm": 18870,
    "lib": 30555
  },
  "visx-shape": {
    "esm": 86912,
    "lib": 108820
  },
  "visx-stats": {
    "esm": 13738,
    "lib": 15320
  },
  "visx-text": {
    "esm": 8567,
    "lib": 10114
  },
  "visx-threshold": {
    "esm": 2907,
    "lib": 3806
  },
  "visx-tooltip": {
    "esm": 15233,
    "lib": 21734
  },
  "visx-vendor": {
    "esm": 2492,
    "lib": 2702
  },
  "visx-visx": {
    "esm": 1524,
    "lib": 4487
  },
  "visx-voronoi": {
    "esm": 2314,
    "lib": 3021
  },
  "visx-wordcloud": {
    "esm": 2620,
    "lib": 3455
  },
  "visx-xychart": {
    "esm": 178434,
    "lib": 240233
  },
  "visx-zoom": {
    "esm": 16239,
    "lib": 19297
  }
}

Current

{
  "visx-annotation": {
    "esm": 31002,
    "lib": 43431
  },
  "visx-axis": {
    "esm": 21783,
    "lib": 26434
  },
  "visx-bounds": {
    "esm": 2948,
    "lib": 3371
  },
  "visx-brush": {
    "esm": 55627,
    "lib": 60219
  },
  "visx-chord": {
    "esm": 3478,
    "lib": 4691
  },
  "visx-clip-path": {
    "esm": 4524,
    "lib": 6062
  },
  "visx-curve": {
    "esm": 323,
    "lib": 1462
  },
  "visx-delaunay": {
    "esm": 2599,
    "lib": 3428
  },
  "visx-demo": {
    "esm": 0,
    "lib": 36731
  },
  "visx-drag": {
    "esm": 12756,
    "lib": 14402
  },
  "visx-event": {
    "esm": 3878,
    "lib": 5194
  },
  "visx-geo": {
    "esm": 13662,
    "lib": 16903
  },
  "visx-glyph": {
    "esm": 15177,
    "lib": 19992
  },
  "visx-gradient": {
    "esm": 18202,
    "lib": 22847
  },
  "visx-grid": {
    "esm": 18982,
    "lib": 22665
  },
  "visx-group": {
    "esm": 1648,
    "lib": 2267
  },
  "visx-heatmap": {
    "esm": 7394,
    "lib": 8731
  },
  "visx-hierarchy": {
    "esm": 12093,
    "lib": 17910
  },
  "visx-legend": {
    "esm": 26944,
    "lib": 34024
  },
  "visx-marker": {
    "esm": 9152,
    "lib": 11350
  },
  "visx-mock-data": {
    "esm": 326040,
    "lib": 329480
  },
  "visx-network": {
    "esm": 4674,
    "lib": 6809
  },
  "visx-pattern": {
    "esm": 11689,
    "lib": 15763
  },
  "visx-point": {
    "esm": 1003,
    "lib": 1818
  },
  "visx-react-spring": {
    "esm": 14040,
    "lib": 17765
  },
  "visx-responsive": {
    "esm": 12972,
    "lib": 16175
  },
  "visx-scale": {
    "esm": 18870,
    "lib": 30555
  },
  "visx-shape": {
    "esm": 86912,
    "lib": 108820
  },
  "visx-stats": {
    "esm": 13738,
    "lib": 15320
  },
  "visx-text": {
    "esm": 8567,
    "lib": 10114
  },
  "visx-threshold": {
    "esm": 2907,
    "lib": 3806
  },
  "visx-tooltip": {
    "esm": 15233,
    "lib": 21734
  },
  "visx-vendor": {
    "esm": 2492,
    "lib": 2702
  },
  "visx-visx": {
    "esm": 1524,
    "lib": 4487
  },
  "visx-voronoi": {
    "esm": 2314,
    "lib": 3021
  },
  "visx-wordcloud": {
    "esm": 2620,
    "lib": 3455
  },
  "visx-xychart": {
    "esm": 178434,
    "lib": 240233
  },
  "visx-zoom": {
    "esm": 16239,
    "lib": 19297
  }
}

Copy link
Contributor

@Lonami Lonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@williaster williaster merged commit a82acb1 into master Mar 8, 2024
2 checks passed
Copy link

github-actions bot commented Mar 8, 2024

🎉 This PR is included in version v3.10.1 of the packages modified 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants