Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "new(axis): add shapeRendering prop to Axis" #1808

Merged
merged 1 commit into from
Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/visx-axis/src/axis/AxisRenderer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ export default function AxisRenderer<Scale extends AxisScale>({
labelProps,
orientation = Orientation.bottom,
scale,
shapeRendering,
stroke = '#222',
strokeDasharray,
strokeWidth = 1,
Expand Down Expand Up @@ -83,7 +82,6 @@ export default function AxisRenderer<Scale extends AxisScale>({
className={cx('visx-axis-line', axisLineClassName)}
from={axisFromPoint}
to={axisToPoint}
shapeRendering={shapeRendering}
stroke={stroke}
strokeWidth={strokeWidth}
strokeDasharray={strokeDasharray}
Expand Down
2 changes: 0 additions & 2 deletions packages/visx-axis/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ export type CommonProps<Scale extends AxisScale> = {
orientation?: ValueOf<typeof Orientation>;
/** Pixel padding to apply to axis sides. */
rangePadding?: number | { start?: number; end?: number };
/** Shape rendering for the lines. */
shapeRendering?: SVGProps<SVGLineElement>['shapeRendering'];
/** The color for the stroke of the lines. */
stroke?: string;
/** The pixel value for the width of the lines. */
Expand Down
Loading