typescript(vx-network): re-write package in TypeScript #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 23, 2019 18:27
…dep, specify types in package.json
Rudeg
reviewed
Sep 26, 2019
|
|
||
| export default function DefaultLink({ link }) { | ||
| return ( | ||
| export default function DefaultLink({ link }: LinkProvidedProps<any>) { |
There was a problem hiding this comment.
can it be LinkProvidedProps<Link<DefaultNode>>?
There was a problem hiding this comment.
I tried this at first, but got TS errors in the Links component when setting linkComponent = DefautlLink along the lines of Link<DefaultNode> is not assignable to Link 😭
wasn't sure of a better solution than this 👎
kristw
reviewed
Oct 2, 2019
| nodes = [], | ||
| nodeComponent = DefaultNode, | ||
| className, | ||
| x = (d: any) => (d && d.x) || 0, |
There was a problem hiding this comment.
x = (d:any) => ... => (d?: {x: number}) => ...
y = (d:any) => ... => (d?: {y: number}) => ...
There was a problem hiding this comment.
this is similar to the defaultLink above, where I get the error Type 'Node' is not assignable to type '{ y: number; }' (even if we default the Node type to { x, y }, it's not guaranteed)
hshoff
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This PR builds off #488 which introduces Typescript build config, and re-writes the
@vx/networkpackage in TypeScript.It also removes an unneeded
d3-forcedependency. Closes #513.💥 Breaking Changes
React.Fragments, which requires bumping thepeerDepforreactto^16.3.0-0<Nodes /><g>elementclassNamechanged to singular (vx-network-nodes=>vx-network-node)<g>was replaced with aReact.Fragment<Links /><g>elementclassNamechanged to singular (vx-network-links=>vx-network-link)<g>was replaced with aReact.FragmentTests
/networkdemo@hshoff @schillerk @milesj @kristw @Rudeg