typescript(vx-group): re-write package in TypeScript #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 11, 2019 14:28
milesj
reviewed
Sep 11, 2019
milesj
reviewed
Sep 12, 2019
3 tasks
williaster
commented
Sep 13, 2019
This was referenced Sep 16, 2019
williaster
changed the title
This was referenced Sep 17, 2019
2 tasks
6 tasks
2 tasks
This was referenced Sep 23, 2019
2 tasks
This was referenced Sep 24, 2019
2 tasks
This was referenced Oct 2, 2019
kristw
approved these changes
Oct 2, 2019
3 tasks
hshoff
approved these changes
Oct 3, 2019
|
whoops, looks like I failed to update the branch this should be merged into to |
2 tasks
3 tasks
3 tasks
This was referenced Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This PR builds off of #484, introducing
TypeScriptconfig and converting the@vx/grouppackage (which is quite simple) as a proof of concept. The plan is to convert packages one by one from here 📈Notes
@types/*related to testing were added to the rootdevDepsdepsin the relevant packages@airbnb/config-babeladdsbabel-plugin-typescript-to-proptypeswhen used with thetypescriptdriver, which generatesPropTypesfor react componenttypes/interfaces and requires us to keep theprop-typesdep though it's no longer referenced in source code. Example compiled.jsfile below:Closes #510
@hshoff @milesj @schillerk @techniq
Fixes https://github.com/hshoff/vx/projects/2#card-26383081