typescript(vx-zoom): re-write package in TypeScript #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rudeg
reviewed
Oct 2, 2019
Rudeg
reviewed
Oct 2, 2019
williaster
force-pushed
the
chris--typescript-vx-zoom
branch
from
4fda899
to
7011bb2
Compare
williaster
force-pushed
the
chris--typescript-vx-zoom
branch
from
0b2f0d9
to
745a201
Compare
kristw
approved these changes
Oct 22, 2019
hshoff
approved these changes
Oct 23, 2019
added 6 commits
October 22, 2019 18:55
williaster
force-pushed
the
chris--typescript-vx-zoom
branch
from
745a201
to
a19eeee
Compare
hshoff
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This PR builds off #488 which introduces Typescript build config, and re-writes the
@vx/zoompackage in TypeScript.Closes #521 , depends on #493 for
@vx/eventtypes.Tests
/zoomdemo.d.tsfiles@hshoff @schillerk @milesj @kristw @Rudeg