-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Zendesk Connector: Adds TicketMetricEvents #8168
Closed
jonoirwinrsa
wants to merge
9
commits into
airbytehq:master
from
CerebriumAI:feature/add-ticket-event-metrics-to-zendesk
Closed
🎉 Zendesk Connector: Adds TicketMetricEvents #8168
jonoirwinrsa
wants to merge
9
commits into
airbytehq:master
from
CerebriumAI:feature/add-ticket-event-metrics-to-zendesk
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonoirwinrsa
changed the title
feat: adds stream config for TicketMetricEvents
Zendesk Connector: Adds TicketMetricEvents
Nov 22, 2021
github-actions
bot
added
the
area/documentation
Improvements or additions to documentation
label
Nov 23, 2021
jonoirwinrsa
changed the title
Zendesk Connector: Adds TicketMetricEvents
🎉 Zendesk Connector: Adds TicketMetricEvents
Nov 24, 2021
marcosmarxm
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution @jonoirwinrsa. I don't have access to your branch to made some small edits (solve conflicts and tests) so I'll publish and merge your code using my PR #8316.
thanks for the contribution @jonoirwinrsa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
community
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Zendesk is missing some useful tables and fields. This adds Ticket Event Metrics which is useful when dealing with SLA breaches.
Related AirByte issue can be found here: #8168
How
Adds
ticket_metric_events
to the schema🚨 User Impact 🚨
There shouldn't be any breaking changes. This only adds another table.
NB: Potential issue
The
time
field has been used as the cursor for this schema. I am not sure if that works as I have intended it?I attempted to generate/use
generated_timestamp
without any luckPre-merge Checklist
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here