Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement manifest metadata #240

Closed
teoyaomiqui opened this issue May 14, 2020 · 8 comments
Closed

Implement manifest metadata #240

teoyaomiqui opened this issue May 14, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release
Milestone

Comments

@teoyaomiqui
Copy link
Contributor

Problem description (if applicable)
This comes from airship 2 design call on thursday 05.14.2020.

Airshipctl config has manifest object, which defines where to and where from to clone git repository with document model. It also defines entry point from where airshipctl starts building document bundle for each phase. At the same time, we have clusterctl object, which defines where are components and versions of the cluster-api for every provider reside inside our document repository and this clusterctl (as of now) object must be stored inside the initinfra phase for now.

In addition to this decided that we should separate document bundle, that holds all baremetal hosts for both ephemeral and target cluster.

All this combined brings us to a chaos of how to keep track of where every document bundle, or single document is inside the repository without introducing an awful user experience.

Proposed change
Add metadata object to manifest repository which would embed all the important entry points inside this specific manifest repo, it would hold such information as:

  • phase directories (where phase bundles entry points are)
  • inventory entry-point, (where all baremetal would be)
  • clusterctl provider components
    maybe more as we go forward...

At the same time airshipctl config manifest object would only hold information where to find this metadata inside the given cloned primary repository

Potential impacts
Some refactoring of CurrentContextEntryPoint and other related methods will be required

@teoyaomiqui teoyaomiqui added enhancement New feature or request triage Needs evaluation by project members labels May 14, 2020
@teoyaomiqui
Copy link
Contributor Author

teoyaomiqui commented May 14, 2020

@jezogwza , @alanmeadows , @dukov , @kozhukalov your input would be very appreciated here.

@dukov
Copy link
Member

dukov commented May 14, 2020

It seem this slowly moving us to read all arishipctl configuration parameters from document model.

@teoyaomiqui
Copy link
Contributor Author

It seem this slowly moving us to read all arishipctl configuration parameters from document model.

Well it seems quite reasonable to me, i would want declarative document model to be source of truth for the resulting clusters, and config simply would tie different clusters together under one roof of airshipctl.

@demonCoder95
Copy link

Is this the one regarding "many commands are needed to get right documents on first deploy" discussion? This looks good, keeping things in one place should remove a lot of user confusion.

@teoyaomiqui teoyaomiqui self-assigned this May 14, 2020
@teoyaomiqui
Copy link
Contributor Author

Is this the one regarding "many commands are needed to get right documents on first deploy" discussion? This looks good, keeping things in one place should remove a lot of user confusion.

that's where it was born, correct

@jezogwza jezogwza added priority/medium Default priority for items and removed triage Needs evaluation by project members labels May 20, 2020
@jezogwza jezogwza added priority/critical Items critical to be implemented, usually by the next release and removed priority/medium Default priority for items labels May 20, 2020
@jezogwza jezogwza added this to the betav1 milestone May 20, 2020
@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Jun 26, 2020
@airshipbot
Copy link

airshipbot commented Jun 26, 2020

Related Change #738146

Subject: Add repository metadata
Link: https://review.opendev.org/738146
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Dmitry Ukov
+1 Ruslan Aliev
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2020-07-10 17:15:08 CDT

@airshipbot
Copy link

A [Related Change](https://review.opendev.org/738146 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Jul 10, 2020
This commit adds repository metadata object and method to load it
from manifests.

Metadata is to be changed and extended in the future, when phases
start to be implemented.

Change-Id: Idc9374220f62df8b1a80c276278361efa4503e12
Relates-To: #263
Relates-To: #255
Relates-To: #240
@teoyaomiqui
Copy link
Contributor Author

closing this issue, as it was implemented, design of metadata will be extended further, for more information see issue #263

@eak13 eak13 removed the ready for review Change related to the issue is ready for review label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release
Projects
None yet
Development

No branches or pull requests

6 participants