-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement manifest metadata #240
Comments
@jezogwza , @alanmeadows , @dukov , @kozhukalov your input would be very appreciated here. |
It seem this slowly moving us to read all arishipctl configuration parameters from document model. |
Well it seems quite reasonable to me, i would want declarative document model to be source of truth for the resulting clusters, and config simply would tie different clusters together under one roof of airshipctl. |
Is this the one regarding "many commands are needed to get right documents on first deploy" discussion? This looks good, keeping things in one place should remove a lot of user confusion. |
that's where it was born, correct |
Related Change #738146Subject: Add repository metadata ApprovalsCode-Review
+2 Dmitry Ukov
+1 Ruslan Aliev
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Matt McEuen Last Updated: 2020-07-10 17:15:08 CDT |
A [Related Change](https://review.opendev.org/738146 was merged. This issue may be ready to close. |
closing this issue, as it was implemented, design of metadata will be extended further, for more information see issue #263 |
Problem description (if applicable)
This comes from airship 2 design call on thursday 05.14.2020.
Airshipctl config has manifest object, which defines where to and where from to clone git repository with document model. It also defines entry point from where airshipctl starts building document bundle for each phase. At the same time, we have clusterctl object, which defines where are components and versions of the cluster-api for every provider reside inside our document repository and this clusterctl (as of now) object must be stored inside the initinfra phase for now.
In addition to this decided that we should separate document bundle, that holds all baremetal hosts for both ephemeral and target cluster.
All this combined brings us to a chaos of how to keep track of where every document bundle, or single document is inside the repository without introducing an awful user experience.
Proposed change
Add metadata object to manifest repository which would embed all the important entry points inside this specific manifest repo, it would hold such information as:
maybe more as we go forward...
At the same time airshipctl config manifest object would only hold information where to find this metadata inside the given cloned primary repository
Potential impacts
Some refactoring of CurrentContextEntryPoint and other related methods will be required
The text was updated successfully, but these errors were encountered: