Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Refactor: Design Metadata File Format #263

Closed
lb4368 opened this issue Jun 3, 2020 · 3 comments
Closed

Config Refactor: Design Metadata File Format #263

lb4368 opened this issue Jun 3, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lb4368
Copy link

lb4368 commented Jun 3, 2020

Proposed change
Design generic metadata file format to be referenced by airship config (#255) for metadata information about the manifests.

See https://go.gliffy.com/go/publish/13297704.

Would this contain a reference to a phase plan (#261)

@lb4368 lb4368 added enhancement New feature or request triage Needs evaluation by project members labels Jun 3, 2020
@jezogwza jezogwza added this to the betav1 milestone Jun 10, 2020
@jezogwza jezogwza removed the triage Needs evaluation by project members label Jun 10, 2020
@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Jun 26, 2020
@airshipbot
Copy link

airshipbot commented Jun 26, 2020

Related Change #738146

Subject: Add repository metadata
Link: https://review.opendev.org/738146
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Dmitry Ukov
+1 Ruslan Aliev
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2020-07-10 17:15:05 CDT

@teoyaomiqui teoyaomiqui self-assigned this Jul 8, 2020
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/738146 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Jul 10, 2020
This commit adds repository metadata object and method to load it
from manifests.

Metadata is to be changed and extended in the future, when phases
start to be implemented.

Change-Id: Idc9374220f62df8b1a80c276278361efa4503e12
Relates-To: #263
Relates-To: #255
Relates-To: #240
@teoyaomiqui
Copy link
Contributor

For now we have designed a basic metadata format, that hold two items only, it will be extended if needed in the future:

// Metadata holds entrypoints for phases, inventory and clusterctl
type Metadata struct {
	Inventory *InventoryMeta `json:"inventory,omitempty"`
	PhaseMeta *PhaseMeta     `json:"phase,omitempty"`
}

// InventoryMeta holds inventory metadata, this is to be extended in the future
// when we have more information how to handle non-baremetal inventories
// path is a kustomize entrypoint against which we will build bundle containing bmh hosts
type InventoryMeta struct {
	Path string `json:"path,omitempty"`
}

// PhaseMeta holds phase metadata, right now it is only path, but maybe extended further
// path is a kustomize entrypoint against which we will build bundle with phase objects
type PhaseMeta struct {
	Path string `json:"path,omitempty"`
}

Closing the issue, as this simple design is sufficient. It's extension should be defined in new issue if needed.

@eak13 eak13 removed the ready for review Change related to the issue is ready for review label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants