[#1041] Minikube provider #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismatix
force-pushed
the
feat/minikube-provider
branch
from
2b75ed5
to
dac2572
Compare
chrismatix
force-pushed
the
feat/minikube-provider
branch
from
dac2572
to
4b2c091
Compare
chrismatix
force-pushed
the
feat/minikube-provider
branch
from
9f1265c
to
f5ebe6f
Compare
lucapette
reviewed
Mar 15, 2021
lucapette
reviewed
Mar 15, 2021
chrismatix
commented
Mar 15, 2021
chrismatix
commented
Mar 16, 2021
chrismatix
commented
Mar 16, 2021
| namespace: {{ .Values.global.namespace }} | ||
| labels: | ||
| app: ngrok-proxy | ||
| spec: |
There was a problem hiding this comment.
A single ngrok tunnel that points to the ingress controller service instead of one per webhook
chrismatix
requested review from
ljupcovangelski,
pascal-holy,
paulodiniz,
AitorAlgorta,
AudreyKj and
ogbeche77
lucapette
reviewed
Mar 17, 2021
lucapette
reviewed
Mar 17, 2021
lucapette
reviewed
Mar 17, 2021
lucapette
reviewed
Mar 17, 2021
Co-authored-by: lucapette <ciao@lucapette.me>
ljupcovangelski
previously approved these changes
Mar 18, 2021
| @@ -47,7 +47,7 @@ These settings are used to connect the **Airy Components** to your Kafka cluster | |||
| - `endpoint` in `<HOSTNAME>:<PORT>` format | |||
| - `dbName` name of the database in the PostgreSQL server | |||
| - `username` these credentials will be passed to the **API Auth Component** | |||
| - `password` and they will be used to create the Postgres if you are deploying with **Vagrant** | |||
| - `password` and they will be used to create the Postgres database | |||
|
|
|||
| ### Components | |||
|
|
|||
There was a problem hiding this comment.
In the ### Applying the configuration section, we should also remove the --kube-config flag, for applying the configuration.
|
|
||
| ```sh | ||
| minikube -p airy-core destroy | ||
| ``` |
There was a problem hiding this comment.
Should we also write a note to delete the record from the /etc/hosts file.
Even though it is not actually a problem, as when the new instance starts - it overwrites the existing one.
There was a problem hiding this comment.
Yeah I wouldn't bother with this for now. Since it does not break anything. Eventually we should have an airy destroy command where we track this for each provider
ljupcovangelski
previously approved these changes
Mar 18, 2021
chrismatix
force-pushed
the
feat/minikube-provider
branch
from
434448c
to
91a93b6
Compare
lucapette
previously approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1041
web-dev.shto run local setupsairy api endpointcommand to easily get the API endpoint