Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1041] Minikube provider #1179
[#1041] Minikube provider #1179
Changes from 36 commits
31cafc1
3bd58c9
4b2c091
c27ee20
f5ebe6f
a1dbd33
74857b5
ccbc1c8
7281182
190464c
d72cdde
10400d7
317e30c
0211d03
d9dfdff
b945bfb
6e17e9f
bc2da29
3ec7b1f
95b06e2
4af9dc0
8f581d8
3d4812a
b57bc68
d118170
25f8c64
88aeed6
a8cbf3b
af320e6
0cad543
10003d7
17ef1e2
35fd4c9
7667ce8
c15ccf1
91a93b6
ae6090f
4dd3ded
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the
### Applying the configuration
section, we should also remove the--kube-config
flag, for applying the configuration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also write a note to delete the record from the
/etc/hosts
file.Even though it is not actually a problem, as when the new instance starts - it overwrites the existing one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I wouldn't bother with this for now. Since it does not break anything. Eventually we should have an
airy destroy
command where we track this for each provider