fix: Add class to tooltip DOM element distinguish errors from warnings (

#4810) * Add class to tooltip DOM element distinguish errors from warnings * Move ClassName to constant + handle undefined / null annotation ClassName
ajaxorg · May 31, 2022 · d2446d6 · d2446d6
1 parent 57ded09
commit d2446d6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/ace/mouse/default_gutter_handler.js b/lib/ace/mouse/default_gutter_handler.js
@@ -87,6 +87,12 @@ function GutterHandler(mouseHandler) {
         tooltipAnnotation = annotation.text.join("<br/>");
 
         tooltip.setHtml(tooltipAnnotation);
+
+        var annotationClassName = annotation.className;
+        if (annotationClassName) {
+            tooltip.setClassName(annotationClassName.trim());
+        }
+
         tooltip.show();
         editor._signal("showGutterTooltip", tooltip);
         editor.on("mousewheel", hideTooltip);

diff --git a/lib/ace/tooltip.js b/lib/ace/tooltip.js
@@ -34,6 +34,8 @@ define(function(require, exports, module) {
 var oop = require("./lib/oop");
 var dom = require("./lib/dom");
 
+var CLASSNAME = "ace_tooltip";
+
 /**
  * @class Tooltip
  **/
@@ -52,7 +54,7 @@ function Tooltip (parentNode) {
 (function() {
     this.$init = function() {
         this.$element = dom.createElement("div");
-        this.$element.className = "ace_tooltip";
+        this.$element.className = CLASSNAME;
         this.$element.style.display = "none";
         this.$parentNode.appendChild(this.$element);
         return this.$element;
@@ -114,6 +116,7 @@ function Tooltip (parentNode) {
     this.hide = function() {
         if (this.isOpen) {
             this.getElement().style.display = "none";
+            this.getElement().className = CLASSNAME;
             this.isOpen = false;
         }
     };