Add class to tooltip DOM element distinguish errors from warnings

[BenSouchet]

Issue #4799 Styling Tooltip Base on Gutter Annotation Type

Description of changes:

Adding required lines to add a CSS class to the tooltip element to distinguish errors from warnings.

Test by building ace from my branch, it's working like a charm:

Not sure about if it the proper way to reset the className with an hardcoded value tho'

[BenSouchet]

The trim() is probably not necessary but I added it because the className value of annotation start with a space, and I haven't seen trim in addCssClass() and/or hasCssClass().

[codecov]

Codecov Report

Merging #4810 (0617677) into master (57ded09) will increase coverage by 0.04%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master    #4810      +/-   ##
==========================================
+ Coverage   71.12%   71.16%   +0.04%     
==========================================
  Files         554      554              
  Lines       55711    55716       +5     
  Branches    10419    10420       +1     
==========================================
+ Hits        39623    39651      +28     
+ Misses      16088    16065      -23     

Flag	Coverage Δ
unittests	71.16% <16.66%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/ace/mouse/default_gutter_handler.js	25.96% <0.00%> (-0.78%)	⬇️
lib/ace/tooltip.js	43.75% <33.33%> (+0.27%)	⬆️
lib/ace/editor.js	81.63% <0.00%> (+1.90%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ded09...0617677. Read the comment docs.

[andrewnester]

Thanks for the PR! Left some comments, but please also add a test for this functionality

[andrewnester]

You can store this class name in some constant / property so in cass it’s changed we change it in one place

[BenSouchet]

I have created a constant var CLASSNAME

[andrewnester]

It might happen that className is undefined or null when annotation type is custom for example, so we should account for this too

[BenSouchet]

I added an if statement to ensure we don't call .trim() and setClassName() with an undefined or null value

[BenSouchet]

Last point it seems there isn't any test for the tooltip.js file (no tooltip_test.js) is there a way to get or generate a starting point for that test file?

Maybe this merge request isn't the best place for the creation and writing of all the tests of the tooltip.js file.

(I think I can manage to add one test to an existing test file but create the whole file with the setup/init process It's would be too difficult for me 🙁 )

[andrewnester]

@BenSouchet sure, no worries about the test, I really thought we had one for tooltip already

[andrewnester]

Merged, thanks for contribution!