Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jshint to 2.13.5 #4911

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Update Jshint to 2.13.5 #4911

merged 2 commits into from
Aug 30, 2022

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Aug 29, 2022

Issue #, if available: #4609

Description of changes:
Update Jshint to 2.13.5

To update jshint to new version:

  1. Clone last version from https://github.com/jshint/jshint
  2. Replace all lodash with underscore in requires in jshint/src/*.js
  3. Add _.slice = require("lodash.slice"); to src/scope-manager.js after var _ = ...
  4. Add _.clone = require("lodash.clone"); to src/jshint.js after var _ = ...
  5. Add "underscore": latest "lodash.clone": "^4.5.0", "lodash.slice": "^4.2.0" to package.json, remove lodash and run npm i
  6. Change in ace/tool/update_deps.js jshint path deps.jshint.browserify.path with your path to changed jshint
  7. Run node update_deps.js jshint

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #4911 (7bbe2bc) into master (e09c92e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4911      +/-   ##
==========================================
- Coverage   85.76%   85.76%   -0.01%     
==========================================
  Files         539      539              
  Lines       40723    40728       +5     
  Branches     6442     6445       +3     
==========================================
+ Hits        34927    34930       +3     
- Misses       5796     5798       +2     
Flag Coverage Δ
unittests 85.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mode/css_completions.js 20.00% <0.00%> (-2.50%) ⬇️
src/editor.js 82.60% <0.00%> (+0.14%) ⬆️
src/layer/text.js 91.31% <0.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrewnester andrewnester self-requested a review August 30, 2022 08:06
@andrewnester andrewnester merged commit 2401fbd into ajaxorg:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants