Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #4976

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Documentation #4976

merged 3 commits into from
Oct 31, 2022

Conversation

anijanyan
Copy link
Contributor

Issue #, if available: #4641, #2719, #2715, #4972

Description of changes: Several small fixes in documentation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 86.06% // Head: 86.06% // No change to project coverage 👍

Coverage data is based on head (91eb6b8) compared to base (bf2913a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4976   +/-   ##
=======================================
  Coverage   86.06%   86.06%           
=======================================
  Files         544      544           
  Lines       41470    41470           
  Branches     6541     6541           
=======================================
  Hits        35691    35691           
  Misses       5779     5779           
Flag Coverage Δ
unittests 86.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ext/language_tools.js 69.64% <ø> (ø)
src/mode/csound_orchestra_highlight_rules.js 97.56% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anijanyan anijanyan marked this pull request as ready for review October 31, 2022 14:33
*/
enableLiveAutocompletion: {
/**
* @param {boolean} val
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still possible to pass an array of completers right?

So instead as suggested in original issue the text should be

Enable basic autocomplete. If the value is an array, it is assumed to be an array of completers and will use them unless you already have completers set e.g. from **enableLiveAutocompletion.**

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The api here is rather strange and not very useful, isn't it better to deprecate passing the array. The users can use completers array directly anyway.

@andrewnester andrewnester merged commit 987ab76 into ajaxorg:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants