-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation #4976
Documentation #4976
Conversation
Codecov ReportBase: 86.06% // Head: 86.06% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #4976 +/- ##
=======================================
Coverage 86.06% 86.06%
=======================================
Files 544 544
Lines 41470 41470
Branches 6541 6541
=======================================
Hits 35691 35691
Misses 5779 5779
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
0cd652b
to
91eb6b8
Compare
*/ | ||
enableLiveAutocompletion: { | ||
/** | ||
* @param {boolean} val |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still possible to pass an array of completers right?
So instead as suggested in original issue the text should be
Enable basic autocomplete. If the value is an array, it is assumed to be an array of completers and will use them unless you already have completers set e.g. from **enableLiveAutocompletion.**
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The api here is rather strange and not very useful, isn't it better to deprecate passing the array. The users can use completers array directly anyway.
Issue #, if available: #4641, #2719, #2715, #4972
Description of changes: Several small fixes in documentation
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.