Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure isort through pyproject.toml #18

Merged
merged 6 commits into from
Jul 9, 2020
Merged

Allow to configure isort through pyproject.toml #18

merged 6 commits into from
Jul 9, 2020

Conversation

Mystic-Mirage
Copy link
Collaborator

Attempt # 2. Decided to rewrite #13 from scratch after #16 due to a lot of conflicts and redundant code

@akaihola your comments from #13 were taken to account:

  • TypedDict for BlackArgs / IsortArgs
  • debug message is readable enough

@Mystic-Mirage Mystic-Mirage marked this pull request as ready for review July 6, 2020 01:27
@Mystic-Mirage Mystic-Mirage requested review from akaihola and CorreyL July 6, 2020 01:27
@Mystic-Mirage Mystic-Mirage mentioned this pull request Jul 6, 2020
Closed
CorreyL
CorreyL approved these changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@CorreyL CorreyL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, especially the introduction of BlackArgs to keep the types in check!

akaihola
akaihola requested changes Jul 8, 2020
View reviewed changes
Copy link
Owner

@akaihola akaihola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really paid off to take the time to refine this feature! I really like the cleanness of the implementation now.

src/darker/import_sorting.py Outdated Show resolved Hide resolved
src/darker/tests/test_import_sorting.py Outdated Show resolved Hide resolved
src/darker/tests/test_import_sorting.py Show resolved Hide resolved
src/darker/tests/test_main.py Outdated Show resolved Hide resolved
@akaihola akaihola mentioned this pull request Jul 8, 2020
Closed
10 tasks
Mystic-Mirage and others added 3 commits July 8, 2020 17:36
@Mystic-Mirage @akaihola
src argument in apply_isort can never be None
21cc623 
Co-authored-by: Antti Kaihola <13725+akaihola@users.noreply.github.com>
@Mystic-Mirage @akaihola
Add extra space between arguments in parametrize
c9fbf1e 
Co-authored-by: Antti Kaihola <13725+akaihola@users.noreply.github.com>
@Mystic-Mirage
Fix test failures caused by required src in apply_isort
c778d9b
@Mystic-Mirage Mystic-Mirage requested a review from akaihola July 8, 2020 14:48
akaihola
akaihola requested changes Jul 8, 2020
View reviewed changes
src/darker/tests/test_main.py Outdated Show resolved Hide resolved
@Mystic-Mirage Mystic-Mirage requested a review from akaihola July 9, 2020 09:08
@Mystic-Mirage Mystic-Mirage merged commit c1909c5 into akaihola:master Jul 9, 2020
@Mystic-Mirage Mystic-Mirage deleted the isort_config_v2 branch July 10, 2020 12:58
@akaihola akaihola added this to the 1.0.0 milestone Jul 11, 2020
@akaihola akaihola added the enhancement New feature or request label Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CorreyL CorreyL CorreyL approved these changes

@akaihola akaihola akaihola approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Darker 1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mystic-Mirage @akaihola @CorreyL